Add a CONST for the Oracle Max Chunk size and replace all occurrences
Open
Nobody has claimed this yet.
3. to review
good first issue
papercut
- Dominant language
- JavaScript
- Stars
- 1k
- Forks
- 348
- Avg merge
- 12h 28m
- Merged PRs (30d)
- 91
Description
We currently use foreach (array_chunk($ids, 1000) as $chunk) pretty much everywhere to chunk IN querys for Oracle.
Change the number to a constant with an expressive name, so people can extrapolate why we use chunking.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for every array_chunk($ids, 1000) occurrence in the PHP sources and inspect how those values are used for Oracle IN queries. Define an expressive constant and replace all matching literals, then verify that no such occurrences remain.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, databases
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100