nextcloud / nextcloud/mail

An additional signature is appended to a draft mail each time it is accessed for editing

Open
#4,289 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop bug
Dominant language
JavaScript
Stars
1k
Forks
348
Avg merge
12h 28m
Merged PRs (30d)
91

Description

Expected behavior

Only one signature text block should be appended to a new message

Actual behavior

An additional signature is added to a draft mail each time the draft mail is accessed (i.e. for editing purposes). The additional signatures each have an additional empty line between their original lines.

See example below where two additional (and flawed) signatures had been added when accessing the e-mail draft two times. The last of the three signatures is the original one and it's fine. The two signatures above are flawed by additional lines and should not be there at all.

Example:

--

Peter Mustermann

Mustermanngasse 3

99887 Musterstadt

--

Peter Mustermann

Mustermanngasse 3

99887 Musterstadt

--

Peter Mustermann
Mustermanngasse 3
99887 Musterstadt

Mail app

1.7.2

Mailserver or service:
sprit.org

Server configuration

Debian 10.3, Apache 2.38, MariaDb 10.3.27, PHP 7.4.13, NC 20.0.4

Client configuration

Firefox 84, Ubuntu 20.04.1 LTS

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or entry point is identified in the issue. Reproduce the problem in Mail 1.7.2 by opening the same draft for editing repeatedly, then trace the draft-editing and signature-handling code and verify that reopening the draft leaves only one signature block.

Written by the indexing model from the issue text.

Assessment

Tech stack
apache, javascript, mariadb, php
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.