Sending with provisioned account fails because of missing From/name
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1k
- Forks
- 348
- Avg merge
- 12h 28m
- Merged PRs (30d)
- 91
Description
Expected behavior
After clicking "Send", the email is send.
Actual behavior
The app says that sending failed with an Error 500, and offers to "Go back" or "Try again".
I was able to resolve the issue by populating the name column of the table oc_mail_accounts with the sql statement update oc_mail_accounts set name=user_id where provisioned='t';, but I guess it would be good if the function that sends emails just takes the value of email in case name is empty?
Mail app
Mail app version: 1.7.1
Mailserver or service: self-hosted (this is not the problem here, just in case someone is wondering)
Server configuration
Operating system: Debian 10
Web server: nginx
Database: PostgreSQL
PHP version: 7.3
Nextcloud Version: 20.0.2.2
Client configuration
Browser: Chromium and Firefox
Operating system: Debian
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the failure when clicking "Send" for a provisioned account whose name is empty, then trace the mail-sending path and how oc_mail_accounts supplies the sender name. Done means sending succeeds by using the email value when name is empty, with a regression test covering that case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, postgresql
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100