nextcloud / nextcloud/mail

Don't hide email address for unknown or spoofed contacts

Open
#3,287 1 comment 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop bug security
Dominant language
JavaScript
Stars
1k
Forks
348
Avg merge
12h 28m
Merged PRs (30d)
91

Description

Expected behavior

If I receive an email from someone (or when someone else is also in the To or Cc header), then their full email address should be shown so it can be verified, unless it is in my contacts.

For example, if the sender on an email is "prime-minister@gov.au" <badactor@malware.com>, or "Dad" <badactor@malware.com> this should be shown in full.

Actual behaviour

The label of the email address is always shown if present.

For example, if the sender on an email is "prime-minister@gov.au" <badactor@malware.com> or "Dad" <badactor@malware.com> this is currently shown as "prime-minister@gov.au" or "Dad".

Mail app

Mail app version: 1.4.0

Mailserver or service: Dovecot

Server configuration

Operating system: Debian 10

Web server: Apache

Database: MariaDB

PHP version: Whatever comes with Debian 10

Nextcloud Version: 19.0.0

Client configuration

Browser: GNOME Web 3.36.2

Operating system: Ubuntu 20.04

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. First reproduce the behavior in the Mail app using a message with a misleading display name and a different address, then trace the email-address rendering entry point. Done means unknown or spoofed senders and recipients show their full address, while contacts may still use their saved label.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.