nextcloud / nextcloud/mail

Migrate off the OCA.Viewer global before Nextcloud 36

Open
#13,662 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop blocked bug
Dominant language
JavaScript
Stars
1k
Forks
348
Avg merge
12h 28m
Merged PRs (30d)
91

Description

Mail opens attachments in the viewer:

  • src/mixins/AttachmentMixin.js:28: OCA.Viewer.mimetypes.includes(fileInfo.mime)
  • src/mixins/AttachmentMixin.js:40: OCA.Viewer.open({ ... })

OCA.Viewer.mimetypes.includes(mime) becomes canView(node), and open() takes
@nextcloud/files nodes rather than the fileInfo object.


OCA.Viewer is gone in Viewer 7.0.0. The viewer ships as the
@nextcloud/viewer library rather than a
bundled app, and nextcloud/server#63954 removes the viewer app from Nextcloud 36 altogether.

Roughly what it looks like:

import { canView, getViewer } from '@nextcloud/viewer'

// OCA.Viewer.open({ path }) / ({ fileInfo, list })
getViewer().open(nodes, file)          // @nextcloud/files nodes
getViewer().openFolder(folder, file)   // when a path is all you have, let it fetch

// OCA.Viewer.mimetypes.includes(mime) / availableHandlers
canView(node)

The part that is not a rename is that the viewer takes @nextcloud/files nodes now, not
fileinfo objects or path strings. Importing the package is also all it takes to get the viewer
onto the page: no LoadViewer event to dispatch, and nothing to check about whether the app is
enabled.

[!IMPORTANT]
There is no compatibility shim, which was a deliberate call, so this is a real port rather
than a rename. Nothing breaks until the server PR lands; after that these calls throw on
Nextcloud 36.

[!TIP]
The developer manual covers the migration under
Critical changes
(being added in nextcloud/documentation#15597), and the
README
has the full before/after table. Happy to help with the port, just ping me.

👾 This issue was written with the help of Claude Code.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/mixins/AttachmentMixin.js at lines 28 and 40, then read the linked nextcloud-viewer migration guidance. Replace the OCA.Viewer usage with the library APIs and convert the file information to @nextcloud/files nodes as needed. Done means attachment viewing works without LoadViewer or viewer-app checks and remains compatible with Nextcloud 36.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
76/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.