Improve Provisoning ManagerTest
Open
Nobody has claimed this yet.
1. to develop
technical debt
- Dominant language
- JavaScript
- Stars
- 1k
- Forks
- 348
- Avg merge
- 12h 28m
- Merged PRs (30d)
- 91
Description
The phpdoc still annotates $user as IUser|MockObject, but the value is now created via createStub(). This makes the annotation inaccurate/misleading (and can confuse IDEs/static analysis). Either update the annotation to IUser/Stub or switch back to createMock() if you want a MockObject here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open tests/Unit/Service/Provisioning/ManagerTest.php at lines 262-263 and compare the $user phpdoc with the createStub() call. Align the annotation and object creation, then run the relevant ManagerTest test suite to confirm it still passes and static-analysis or IDE warnings are resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100