nextcloud / nextcloud/mail

IMAPMessage violating the IMessage contract

Open

#12,530 opened on Mar 6, 2026 2 comments 1 reaction 2 assignees View on GitHub

@kesselb is already working on this.

Since Mar 6, 2026.

1. to develop technical debt

Dominant language: JavaScript
Stars: 1k
Forks: 348
Avg merge: 12h 28m
Merged PRs (30d): 91

Description

The interface is implemented by OCA\Mail\Model\Message and OCA\Mail\Model\IMAPMessage.

https://github.com/nextcloud/mail/blob/52214dca31a4be8b3a166350f4ae8b91a0b24d30/lib/Model/IMessage.php#L119-L122

`OCA\Mail\Model\Message` is okay:

https://github.com/nextcloud/mail/blob/52214dca31a4be8b3a166350f4ae8b91a0b24d30/lib/Model/Message.php#L291-L305

`OCA\Mail\Model\IMAPMessage` is not:

https://github.com/nextcloud/mail/blob/52214dca31a4be8b3a166350f4ae8b91a0b24d30/lib/Model/IMAPMessage.php#L385-L391

https://github.com/nextcloud/mail/blob/52214dca31a4be8b3a166350f4ae8b91a0b24d30/lib/IMAP/ImapMessageFetcher.php#L304-L312

https://github.com/nextcloud/mail/blob/52214dca31a4be8b3a166350f4ae8b91a0b24d30/lib/IMAP/ImapMessageFetcher.php#L337-L345

Solution

Drop the interface?

It looks like we are always using the actual classes instead of the interface.

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

A short digest of beginner-friendly GitHub issues.