nextcloud / nextcloud/mail

✨ Enhance "The images have been blocked to protect your privacy."

Open
#12,075 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3. to review enhancement
Dominant language
JavaScript
Stars
1k
Forks
348
Avg merge
12h 28m
Merged PRs (30d)
91

Description

Is your feature request related to a problem? Please describe.

The element "The images have been blocked to protect your privacy." is not really readable with the color --color-text-maxcontrast (weird right) and doesn't look good.

Describe the solution you'd like

Instead of putting into the email iFrame, make it a separate section like the phising warning.

Describe alternatives you've considered

I tried changing its color to just black, better, but not consistent with the button - it needs rework as a whole.

Additional context

Should be pretty easy, but I won't be getting into this as I don't have that much time lately.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the codebase for the exact blocked-images message and inspect how the phishing warning is rendered. Move the blocked-images notice into a separate section rather than the email iframe, with readable styling consistent with the button; verify the message and surrounding email view visually.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.