nextcloud / nextcloud/mail

Message might stuck in the outbox with an smtp error.

Open
#10,591 3 comments 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop bug
Dominant language
JavaScript
Stars
1k
Forks
348
Avg merge
12h 28m
Merged PRs (30d)
91

Description

Steps to reproduce

https://github.com/nextcloud/mail/blob/98804d97d11c2d566d506575edce9917a6b09af1/lib/Service/MailTransmission.php#L147-L152

https://github.com/nextcloud/mail/blob/98804d97d11c2d566d506575edce9917a6b09af1/lib/Send/Chain.php#L41-L48

  • The log statement in MailTransmission lacks any context and is therefore hard to match to an actual message / account.
  • The chain is called over and over again for messages in the outbox and will pollute the log file without providing any useful information.
Expected behavior
  • Log the problem with context
  • Don't log the same error over and over again

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/Service/MailTransmission.php lines 147-152 and lib/Send/Chain.php lines 41-48. Trace how SMTP errors are logged and how messages are retried in the outbox. Done means the log identifies the relevant message or account and repeated failures do not pollute the log with the same error.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.