nextcloud / nextcloud/logreader

See what we can do about false positive in EasyList/EasyPrivacy ad blocker

Open
#1,136 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
69
Forks
30
Avg merge
10h 28m
Merged PRs (30d)
57

Description

Can we fix that?

Originally posted by @Dennis1993 in https://github.com/nextcloud/logreader/issues/1134#issuecomment-1913312715

Looks like the rule that matches is this one:

https://github.com/easylist/easylist/blob/cc978eaf9a634160e89252ff804fb5bffd1e5a71/easyprivacy/easyprivacy_general.txt#L305

Not sure there's much we can do about this, but worth looking into before we rule it out.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the false positive in logreader with the EasyPrivacy rule linked at easyprivacy_general.txt line 305, then compare the behavior with that rule disabled. Determine whether the issue can be addressed in logreader or must be reported to EasyList, and document the result.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.