nextcloud / nextcloud/ldap_write_support
Check for failure on setting the Mail
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 33
- Forks
- 14
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 13
Description
The return value of ldap_mod_replace is not checked when setting the Mail. Would be nice to check for that and to throw an exception in case of failure.
This is not only a theoretical concern: I am currently trying to enforce unique E-Mails through LDAP and setting a non-unique one just silently fails at the moment.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the code that calls ldap_mod_replace when setting the Mail attribute and inspect how failures are currently handled. Confirm the return value is checked and that a failed update raises an exception, including the non-unique email case described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100