nextcloud / nextcloud/ios

Handling of conversation shares

Open
#654 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
2.5k
Forks
1k
Avg merge
2d 18h
Merged PRs (30d)
13

Description

In Nextcloud 14 there was a new share type introduced: 10
https://github.com/nextcloud/server/blob/857bb4536628814cdae3591c795bb1e21e9704b7/lib/private/Share/Constants.php#L42

It would be nice if the shares are flagged as displayname (conversation) when listing all the shares, and when you also would allow to create such shares in the client. You can test this easily, by going to an instance with talk installed, create a conversation "Test room", go to the files app, open the share sidebar and try to share with "Test room". There should be a suggestion Test room (conversation)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the iOS Files app's share sidebar and trace how existing share types are listed and created. Use a Talk instance with a conversation named "Test room" to verify that type 10 appears as "Test room (conversation)" and can be selected for sharing.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.