File or folder shared by shared link and by internal share simultaneously is displayed in cell as non-shared
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 2.5k
- Forks
- 1k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 13
Description
This is NextCloud behaviour (present in 6.6.0)
When folder or file is shared by several share types (internally and by shareLink), the set of shareType info is empty and from iOS client it is visible as not shared.
Place of error:
NextCloudKit: NKDataFileXML, lines 393...397, parsing of shareTypes
Value returned in string 394 is not an int, it is a sequence. That's why it can not be casted as Int and the line 395 is skipped.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in NextCloudKit: NKDataFileXML around lines 393-397 and inspect how shareTypes are parsed when a file or folder has both an internal share and a share link. Reproduce that combination and verify the returned share information is retained so the iOS client displays the item as shared.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 65/100