nextcloud / nextcloud/ios

Wrong Readme.md prohibit folder listing

Open
#3,216 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Swift
Stars
2.5k
Forks
1k
Avg merge
2d 18h
Merged PRs (30d)
13

Description

Hello

If a folder contains a Readme.md file with an accented character (é, è, à ... ) encoded in iso-8859-1 in its content, then the parent folder is not available for the iOs client.

How to reproduce:

  • create a folder ‘test’ with two subfolders ‘test/a’ and ‘test/b’:
  • on the iOs client, the test folder is displayed correctly and shows folder a and folder b.
  • now, put in the folder ‘test/a’ a Readme.md that contains an accented character encoded in “iso 8859-1”:
  • now, on the iOs client, the test folder is displayed empty.
  • Rename the test/a/Readme.md to test/a/Readme_old.md.
  • now, on the iOs client, the test folder displays its two subfolders.

Easy, right? but it took me a long time to find this... after suspecting a long delay (because when I first encountered this failure it was with a big file), optimizing my server, etc. and finally finding it!

I can provide you with some examples.

tested with Nextcloud ios client 6.1.6 and Nextcloud Hub 9 (30.0.2).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by reproducing the issue with the described iOS client folder structure and an ISO-8859-1 Readme.md containing an accented character, then trace how folder listings handle that file. Done means the parent folder still displays its subfolders in the iOS client.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.