nextcloud / nextcloud/ios

Prevent enforced password removal when creating or editing a share

Open
#2,960 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
2.5k
Forks
1k
Avg merge
2d 18h
Merged PRs (30d)
13

Description

Steps to reproduce
  1. Setup your server to enforce password protection on shares
  2. Create or edit a share
Expected behaviour

Based on the capabilities (I guess ?) from the server, we should not be able to remove password protect in this view :
Screenshot 2024-06-26 at 09 01 49 jpeg

Actual behaviour

Instead we can change it but then when sharing we get the expected following error :
Screenshot 2024-06-26 at 09 15 54 jpeg

Reasoning or why should it be changed/implemented?

Because as users we can lose all other changes we made to the share since the creation/editing of the share fails.

Environment data

Nextcloud iOS app version: 5.3.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by enabling enforced password protection on the server, then create or edit a share in the iOS app. Trace the share creation/editing entry point and how server capabilities are read. Done means the view prevents removing password protection when enforcement is active and other share changes are not lost.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.