nextcloud / nextcloud/ios

Cannot (easily) reset folder colour

Open
#2,629 0 comments 0 reactions 1 assignee View on GitHub

@marinofaggiana is already working on this.

Since Oct 9, 2023.

design enhancement
Dominant language
Swift
Stars
2.5k
Forks
1k
Avg merge
2d 18h
Merged PRs (30d)
13

Description

Steps to reproduce
  1. Click on the ... of a file
  2. Click on "Change colour"
  3. Select a colour
  4. Click on ... and "Change colour" again
Expected behaviour

There should be a button "Reset colour"

Actual behaviour

There is no Reset button.

The only way to reset it is via the color picker and the Eyedropper tool. With the Eyedropper you can get the instance theme colour from one of the other folders or from the (+) button and apply it.

Screenshots

(Yes, the green in the bottom right is my server theme colour. But it was only added after I picked it with the Eyedropper. And even then, an explicit Reset is easier to find.)

Logs
n/a
Reasoning or why should it be changed/implemented?

It seems like an obvious thing a user would want to do.

Environment data

iOS version: iPadOS 17.0.3

Nextcloud iOS app version: 4.9.0.16

Server operating system: Ubuntu

Web server: Apache

Database: MariaDB

PHP version: 8.1

Nextcloud version: 27.1.1

Misc comment
  1. More generally, I am surprised that folder colours are a client-side feature? I would have expected this to be a server feature, syncing to all clients.
  2. Design feedback: the title of the picker could use more padding. It looks crammed towards the top. Also outer border padding is smaller than the padding between colours. ==> Make the outer padding of the entire popup the same as the padding inbetween the colours.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.