nextcloud / nextcloud/ios

Do not reorder list when a file has been favourited

Open
#1,961 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
2.5k
Forks
1k
Avg merge
2d 18h
Merged PRs (30d)
13

Description

Steps to reproduce
  1. On your iPhone, open your awesome Nextcloud app
  2. Locate some file X at the very bottom of a very long directory in the file browser.
  3. Click on the triple point menu "..." on the left and choose “Add to favourites”
  4. That file seems like it's gone, not showing up anymore in the file browser
  5. But it appears under the favourites tab
Expected behaviour

I expect favourite files to appear in the file browser and under favourites both. Don't have to remove it in the file browser nor alter its sorting logic.

Because not everyone can remember if file X has been "favourite"-ed or not. Keep it in both places pretty please.

Actual behaviour

Once file X has been favourited, it looks like it has disappeared in the file browser and only shows up under the favourites tab which is wrong IMO.

But heck, no, that favourited file still appears on top of that directory against the sorting logic to sort it by A to Z.

Reasoning or why should it be changed/implemented?

A directory should always reflect its files no matter what, in the same sorting logic, not ruling out favourites. Why?

Environment data

iOS version: iOS 15.4.1

Nextcloud iOS app version: 4.3.1.0 ... but actually this doesn't matter. This issue has been bugging me for many months.

....

Happy to discuss anything further. I think this usability issue is a big problem. Thanks for your awesome work. Please give this one issue attention. Peace out.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the iOS file browser with a long directory, then trace the file browser's favorite handling and sorting behavior. Done means favoriting a file leaves it in its directory and preserves the selected sort order while it also appears under Favorites.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.