file upload: content-type: application/x-www-form-urlencoded is bloating the request body
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 2.5k
- Forks
- 1k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 13
Description
In addition to the problem described in https://github.com/nextcloud/ios/issues/1942 the application/x-www-form-urlencoded also bloates the size of the request body. I don't think that using url encoding for binary data upload is the best choice.
Expected behaviour
Using content-type: application/octet-stream
Actual behaviour
Using content-type: application/x-www-form-urlencoded bloats request body size.
Environment data
iOS version: iOS 15.4
Nextcloud iOS app version: 4.3.1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the related issue #1942 and locating the iOS file-upload request path; the issue names no source file or test. Verify the current content type and request body sizing, then consider it done when binary uploads use application/octet-stream without the reported body bloat.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100