Not able to dismiss Viewer when not able to load
Open
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 2.5k
- Forks
- 1k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 13
Description
Steps to reproduce
Related:
- Tap "+"
- "Create new document"
- Get a server failure
Expected behaviour
If the server for some reason cannot load the appropriate viewer it should either
- not open in the first place
- close automatically
- have the ability to close the viewer manually by the user (e.g. by having a close button in the navigation bar)
Actual behaviour
The app gets 'stuck'. There is no way to manually close the viewer. The app needs to be force quit.
Screenshots
Reasoning or why should it be changed/implemented?
Making it easier and saver to use the app in case of a sever failure.
Environment data
iOS version: e.g. iOS 14.5 / 15.2
Nextcloud iOS app version: 4.1.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the listed flow: tap "+", choose "Create new document," and trigger a server failure while the viewer loads. Trace how the viewer is presented and handles this failure; done means the app does not get stuck and the user can dismiss or automatically leave the viewer.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100