nextcloud / nextcloud/ios

Overwriting original in annotation mode does not work

Open
#1,629 6 comments 4 reactions 1 assignee View on GitHub

@thisIsTheFoxe is already working on this.

Since Mar 14, 2022.

  • #1926 by @thisIsTheFoxe — merged
Dominant language
Swift
Stars
2.5k
Forks
1k
Avg merge
2d 18h
Merged PRs (30d)
13

Description

Steps to reproduce
  1. Use Nextcloud Liquid for iOS 4.0.1.1
  2. Open context menu of pdf file (three dots)
  3. Select annotate(?)/change with the pencil icon in the circle (DE: Ändern)
  4. Draw something in the document
  5. Press Done and select overwrite original
  6. Reopen the document to check if changes were saved
  7. Be sad you lost 2h of annotations
    (Saving a copy works)
Expected behaviour

When overwriting the original, it should be writting to storage and nextcloud. Changes shouldn't disappear.

Actual behaviour

Nothing is saved, all is lost.

Reasoning or why should it be changed/implemented?

It means data loss, which is really frustrating and damaging to the perception of NC quality.

Environment data

iOS version: e.g. iOS 14.6

Nextcloud iOS app version: Nextcloud Liquid for iOS 4.0.1.1

Operating system: Linux 4.15.0-88-generic #88-Ubuntu SMP Tue Feb 11 20:11:34 UTC 2020 x86_64

Webserver: nginx/1.18.0 (fpm-fcgi) + nginx reverse proxy

Database: mysql 10.3.29

PHP version: 7.4.3

Modules loaded: Core, date, libxml, openssl, pcre, zlib, filter, hash, Reflection, SPL, session, standard, sodium, cgi-fcgi, mysqlnd, PDO, xml, apcu, bcmath, calendar, ctype, curl, dom, mbstring, FFI, fileinfo, ftp, gd, gettext, gmp, iconv, igbinary, imagick, intl, json, exif, mysqli, pdo_mysql, apc, posix, readline, redis, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, xmlreader, xmlwriter, xsl, zip, Phar, Zend OPcache

Nextcloud version: 21.0.2 - 21.0.2.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.