nextcloud / nextcloud/ios

Getting push notifications for deleted accounts

Open
#1,608 3 comments 1 reaction 1 assignee View on GitHub

@marinofaggiana is already working on this.

Since May 31, 2021.

bug
Dominant language
Swift
Stars
2.5k
Forks
1k
Avg merge
2d 18h
Merged PRs (30d)
13

Description

Steps to reproduce
  1. setup two accounts (in my case from two different Nextclouds) in the iOS app
  2. delete one of them from the iOS app
  3. create a notification on the server (for testing admin_notification app is the easiest) for this deleted account
Expected behaviour

There is no push notification on the device, because the account was removed.

Actual behaviour

A notification with "Nextcloud notification" as text is shown on the device.

Screenshots

abc

Reasoning or why should it be changed/implemented?

I remember that we had discussions in the past that there was a "Push notification could not be decrypted" message. This seems to be the same but with different text. But there are two things to fix:

  • if there comes a notification that can't be decrypted: don't show it as it has no value at all
  • try to avoid the push in the first place: on account deletion the push registration should be removed as well

cc @marinofaggiana

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.