Sort menu displays wrong item, then always shows one sort
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 2.5k
- Forks
- 1k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 13
Description
Expected behaviour
Clicking "Sort by newest" should sort by newest. The sort menu should then display "Sort by oldest". Clicking it should sort by oldest. The menu should then display "Sort by newest". etc.
Actual behaviour
Click "Sort by newest". You actually end up with "Sort by oldest." Then, the menu displays "Sort by oldest" and if you keep clicking it, the sort does indeed flip back and forth between the two but the sort menu always shows "Sort by oldest."
The analogous thing happens with largest/smallest. A to Z, interestingly, also gets stuck, but clicking A to Z initially does get you sort by A to Z
Steps to reproduce
See above.
Reasoning or why should it be changed/implemented?
It's buggy and unintuitive to use.
iOS version
14.3
App version
3.1.0.7
Server configuration
Operating system: Ubuntu 18.04.5
Web server: snap latest
Database: snap latest
PHP version: snap latest
Nextcloud version: snap latest (20.0.4)
Additionally, the UX could be improved slightly if you didn't have to go to the menu twice to get the reverse sort options. If you instead had a "Reverse sort" checkbox that worked independently of the sort chosen that simply changed all of the sort menu options, I think that would be a better way to do things.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the sort-menu behavior on the iOS app using the reported newest/oldest and largest/smallest cases, then locate the implementation for that menu and its sort-state handling. Done means each menu selection applies the requested order and the displayed option correctly indicates the reverse sort, including the A-to-Z case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100