"Offline Favorites" leads to crashes and unsolicited downloads
Open
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 2.5k
- Forks
- 1k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 13
Description
Expected behaviour
Enabling offline favorites should only download files marked as favorites
Actual behaviour
App often crashes when browsing to a folder for the first time. Second time around, it pulls all files in that folder into the offline cache
Steps to reproduce
- disable offline favorites
- clear cache
- enable favorites
- see files in root folder getting pulled again
- browse to a different folder
- app either crashes or pulls all files
Reasoning or why should it be changed/implemented?
Waste of cache space and data traffic. Also, crashes suck
iOS version
14.0.1
App version
3.0.12(4)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Reproduce it on iOS 14.0.1 with app version 3.0.12(4) by clearing the cache, enabling offline favorites, and browsing into another folder. Done means favorited files alone are downloaded and browsing does not crash.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100