nextcloud / nextcloud/ios

Improve app identifier string in "devices and sessions" list

Open
#1,313 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Swift
Stars
2.5k
Forks
1k
Avg merge
2d 18h
Merged PRs (30d)
13

Description

Expected behaviour

The app should identify itself towards the nextcloud server with a device string that contains usable information. This is solved very well by the talk app, which identifies itself with the string "$DEVICE_NAME (Nextcloud Talk)", see screenshot below. The string of the files app is lacking information. I suggest to change the string to "$DEVICE_NAME (Nextcloud Files)" to set it in line with talk. Also, this helps to seperate the devices if more than one is used.

Note: If this enhancement request is accepted it should be spread to other apps such as android and desktop client.

Actual behaviour

The app identifies itself with "Nextcloud iOS app Nextcloud" which is lacking any information and holds the word "Nextcloud" two times for no reason
see:
grafik

Steps to reproduce

Install app
Connect to your nextcloud
Check the entries in the "devices and sessions" list

Reasoning or why should it be changed/implemented?
iOS version

13.5

App version

2,25,9,2

Server configuration

Nextcloud version: 19.0.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the iOS codebase for the current identifier string "Nextcloud iOS app Nextcloud" and trace where the devices-and-sessions app name is assembled. Update it to include the device name and "(Nextcloud Files)", then connect the app to a Nextcloud server and verify the resulting entry in the devices and sessions list.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.