Files app integration - Favorites list
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 2.5k
- Forks
- 1k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 13
Description
Expected behaviour
When a folder with favorite flag deleted from nextcloud client, files client also remove the folder from favorites list, or at least have the ability to remove the favorite folder from the files app
Actual behaviour
Nextcloud client incorrectly populates the removed folder to files app's favorite list. Even it is removed from the files app it reappears instantly.
Steps to reproduce
Create a folder in nextcloud app
Make the folder favorite
Open files app and see it is added to favorites list
Delete the folder without removing favorite flag
Open files app, favorites list still displays the folder
Remove the folder from favorites list in files app
Instantly the favorite would reappear
Clicking on the folder opens the root nextcloud folder
The behavior persists until the nextcloud app is removed, this removes all the nextcloud favorite folders from the files favorites list.
iOS version
13.3 (17C54) (iPad Pro 12.9" 2017)
App version
2.25.5
Server configuration
Operating system:
ubuntu
Web server:
apache
Database:
mysql
PHP version:
7.3
Nextcloud version: (see Nextcloud admin page)
Nextcloud 17.0.2
Note: Removing a folder from favorites using files app also removes the favorite flag in the nextcloud client, if the folder is not deleted. Also restoring the folder does not correct the behavior.
The workaround is easy, just uninstall the app and reinstall it, it simply cleans the mess.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the favorite-folder deletion flow between the Nextcloud client and the iOS Files app using the listed steps, then trace the favorites-list integration and folder restoration behavior. Done means a deleted folder is removed from the Files app favorites list, cannot immediately reappear, and existing favorite folders continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100