nextcloud / nextcloud/integration_docusign

[DOCUSIGN] Paid integration

Open
#118 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
6
Forks
1
Avg merge
1d 6h
Merged PRs (30d)
6

Description

Hello,

Thanks for your time, and effort to make this software.

We wanted to be able to request signature from pdf document via nextcloud. I have see the Integration provided here and at forst it seem to work.
Creating a develloper account, adding an App in App & Keys. Pasting value and saving them in nextcloud worked like a charm.

We have made test and it work like we intended to have it, so we followed the process to "GoLive".

Here documentation is laking, but we managed to have an account with a paid API Plan.

Once the app is live you have to : https://developers.docusign.com/docs/esign-rest-api/go-live/after-go-live/

Defining OAuth settings for production
So same app key but new secret.

Using production API endpoints
Here I had to go to : https://github.com/nextcloud/approval/blob/e9d2b5588adc8e4409127853552458d60aa9dcb5/lib/AppInfo/Application.php#L48-L49
And remove the -d from the domain.
And go to : https://github.com/nextcloud/approval/blob/e9d2b5588adc8e4409127853552458d60aa9dcb5/js/approval-adminSettings.js#L2
To do the same.

Without those modification I wasn't able to login as production account so requested sign where non valid.
Here was the log : 400 Bad Request response: {"error":"invalid_grant","error_description":"unauthorized_client"

Maybe we should have in admin, a check box to switch between production and devellopment.

if productionAccount === true { baseDomain = account } else { baseDomain = account-d }

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading lib/AppInfo/Application.php around the production API domain and js/approval-adminSettings.js around the client domain, as linked in the issue. Add an admin setting to select development or production endpoints, then verify that production login and signature requests use the production domain instead of the -d domain.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, backend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.