nextcloud / nextcloud/integration_documenso

Feedback

Open
#6 0 comments 0 reactions 1 assignee View on GitHub

@janepie is already working on this.

Since Nov 25, 2024.

enhancement
Dominant language
JavaScript
Stars
12
Forks
2
PR merge metrics
No merged PRs in 30d

Description

  • One eslint warning left about src/components/PersonalSettings.vue line 20 (displayed when compiling or with npm run lint)
  • IMO The URL should be stored as set by the user (no stripping + adding trailing slash). So the value loaded after a page refresh is not different than what the user has set. The trailing slash should only be added when the URL is used to make a network request (calling the API and redirecting the user). Wdyt?
  • Could you check if it's possible to display something informative in the dashboard widget if the app is not configured?
  • IMO the API token should be "validated" when setting a new value. One simple and useful way to check it would be to use it to get information about the documenso account. Then you can even store this information (display name, user ID etc...) and display it in the settings. You can even hide the API token input and replace it with a "disconnect" button which clears the token value and deletes all the user info.
  • You could pass the info to the frontend (initial state or request when opening the modal) that the user is connected or not (valid api token) so that the modal could display something if no api token is set (or it's not valid). You could just say: "Nope, not connected to any documenso account, check the connected account settings" + a link/button to get there.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.