nextcloud / nextcloud/helm

Feature: Allow configuring SSL for the default NGINX config file

Open
#709 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement support
Dominant language
Go Template
Stars
534
Forks
314
Avg merge
42m
Merged PRs (30d)
1

Description

Description of the change

Allow setting properties in the values.yaml for NGINX which update the default configuration to use SSL.

Benefits

This will make it easier to setup SSL on the NGINX instance, as currently the only option is to copy the filled-in config file from the config map and adding the necessary settings, then disabling the default file and pasting it in the custom one.

The example configuration from NGINX I think should be enough for most use cases. This change will make it easy to setup mTLS inside the cluster without needing a server mesh or other such systems.

Possible drawbacks

Added complexity to the default file and values.yaml, but it should be decent to manage.

Additional information

See how Grafana's Loki does it for their NGINX gateway as an example of the values.yaml properties.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the chart's values.yaml and the default NGINX configuration exposed through its config map. Compare the proposed values with Grafana Loki's NGINX gateway configuration and verify that the selected SSL and mTLS settings render a valid default configuration; done means users can configure SSL without copying and disabling the default file.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes, nginx
Domain
devops, infrastructure
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.