nextcloud / nextcloud/helm

if ingress tls is enabled, then adjust the config file to overwriteprotocol https as needed so reverse proxy works

Open
#705 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go Template
Stars
534
Forks
314
Avg merge
42m
Merged PRs (30d)
1

Description

Description of the change

Whatever changes are needed to config file to make a reverse proxy work should happen automatically if an ingress is enabled with tls.

Benefits

Folks deploying via helm chart should not have to know that they need to add a config section to get their reverse-proxy to work. It should be enough that they enabled an ingress with tls.

Possible drawbacks

None

Additional information

I had to add the following config to get the reverse-proxy to work, but every one deploying shouldn't have to dig this up every time, it should just be added automatically if an ingress was enabled with tls.

  nextcloud:

    # this is required or the reverse-proxy w/ ingress won't work
    configs:
      custom.config.php: |
        <?php
        $CONFIG = array (
          'overwriteprotocol' => 'https',
          'filelocking.enabled' => 'true',
          'enable_previews' => true,
        );

Since I'm not an expert I don't know if this config file overwrites default settings that I might actually need, or if it just appends these to an existing configuration. By just taking care of things for me, in response to enabling an ingress with tls, things will just work by folks who know the details and just take care of what needs to be taken care of automatically.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names Helm ingress with TLS and the custom.config.php configuration, but gives no repository path or test. Start by locating the chart's ingress and Nextcloud configuration entry points, then verify that enabling ingress TLS makes reverse-proxy requests work without manually adding the shown configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
cloud, infrastructure
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.