nextcloud / nextcloud/helm

New S3 Configuration breaks prior S3 configuration and is missing uploadPartSize

Open
#612 11 comments 1 reaction 1 assignee View on GitHub

@jessebot is already working on this.

Since Sep 25, 2024.

bug S3
Dominant language
Go Template
Stars
534
Forks
314
Avg merge
42m
Merged PRs (30d)
1

Description

Describe your Issue

I've used the S3 integration before "manually" via configs.s3.config.php, now the helm chart upgrade (v5.4.0) fails because it's already defined

Logs and Errors

Helm upgrade failed: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors:
line 168: mapping key "s3.config.php" already defined at line 23

Describe your Environment

  • Kubernetes distribution: k8s

  • Helm Version (or App that manages helm):

  • Helm Chart Version: 5.4.0

  • values.yaml:

configs:
        s3.config.php: |-
          <?php
          $CONFIG = array (
            'objectstore' => array(
              'class' => '\\OC\\Files\\ObjectStore\\S3',
              'arguments' => array(
                'hostname'         => 's3.eu-central-2.wasabisys.com',
                'bucket'           => '...',
                'autocreate'       => false,
                'key'              => '...',
                'secret'           => '...',
                'region'           => 'eu-central-2',
                'use_ssl'          => true,
                'use_path_style'   => false,
                'uploadPartSize'   => '2097152000'
              )
            )
          );

Additional context, if any

  1. It would be nice if such a change would be marked as a breaking change next time
  2. The chart should respect the manually set configuration
  3. The new options are missing uploadPartSize, which is required to be set there for some reason on S3 storage, so I can't even switch to the new configuration style

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.