nextcloud / nextcloud/guests

automatically remove disabled apps from white list

Open
#257 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug papercut
Dominant language
JavaScript
Stars
61
Forks
34
Avg merge
3d 19h
Merged PRs (30d)
22

Description

By default the app white-list contains the Gallery app, which should be deactivated in newer Nextcloud releases in favor of the Viewer app (afaik). If the Gallery app has been deactivated and you install the Guests app, the Gallery app is still listed in the summarized white-list and cannot be removed because of its deactivation state.

I would recommend to remove all disabled apps automatically from the list:

Summarized white-list:

grafik

List of apps selectable/unselectable for white-listing:

grafik

Environment

Nextcloud v17.0.2
Guests app v1.3.1
Browser: Firefox v72.0.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Reproduce the reported setup with the Gallery app disabled and the Guests app installed, then locate the code that builds the summarized white-list and the selectable app list. Done means disabled apps no longer appear in either white-list view and cannot block the configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.