nextcloud / nextcloud/guests

Allow the + sign in users (aka in mail)

Open
#1,447 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement
Dominant language
JavaScript
Stars
61
Forks
34
Avg merge
3d 19h
Merged PRs (30d)
22

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature request

In email addresses, it is possible to use the + sign (hello+bye@blabla.com, etc.), but Guests does not allow it.

Reference: https://en.wikipedia.org/wiki/Email_address (local-part)

Would it be possible to allow this character?

BR,
Marc

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by locating the email-address validation used when creating guest users, then check how its allowed local-part characters are defined. Done means addresses such as hello+bye@blabla.com are accepted without weakening other validation rules, with the relevant tests passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.