nextcloud / nextcloud/guests

Guests whitelist revision

Open
#1,249 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement feature: whitelist
Dominant language
JavaScript
Stars
61
Forks
34
Avg merge
3d 19h
Merged PRs (30d)
22

Description

Ref source: https://github.com/nextcloud/guests/blob/053c96a0113e1e4e47f253d3ce9b1ac81416fb39/lib/AppWhitelist.php#L52-L54

WHITELIST_ALWAYS and DEFAULT_WHITELIST could be updated to include some more of the apps shipped (and enabled by default) with Nextcloud core, to avoid confusion like "Guest account can't preview PDF files", as files_pdfviewer is not included in the default list.

https://github.com/nextcloud/server/blob/356f3ded52cf48a26295daef96c032d6d087a518/core/shipped.json#L56

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read lib/AppWhitelist.php around lines 52-54, then compare the default-enabled applications listed in Nextcloud core's core/shipped.json around line 56. Update WHITELIST_ALWAYS and DEFAULT_WHITELIST to include the appropriate shipped apps, including files_pdfviewer, and verify the whitelist reflects the selected core apps.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authorization
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.