nextcloud / nextcloud/groupfolders

Make it clearer who has access

Open
#975 1 comment 19 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement feature: sharing
Dominant language
PHP
Stars
343
Forks
106
Avg merge
2d 3h
Merged PRs (30d)
34

Description

I think Group Folders seem to be a very good feature however I also have a big issue that I think is a minor fix.

If I set up a group folder, lets say I add the Groups:
Sales, Legal and Board

I want only Board and Legal to access some folders, for example with employment contracts. So I press the Share button of Employment Contracts subfolder and I want to make sure only Legal and Board will have access. I then add Board and Legal and give them full access to this folder.
Now I realise I also need to add the Sales group and Deny it access, fair enough but here is the problem, this is too complex, if I forget about the Sales group they will have full access and I will not even see them in the list. Also if I add another User Group to the group folder in the future it will have full access to these restricted folders.

One way to make this more clear I think is if the Group Folder permission list of a folder would always display all groups added to the Group Folder. The ones that only inherit permissions could be greyed out instead. But this way you would at least immediately see and understand who has access to a specific folder.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Group Folder permission list for a restricted subfolder and reproduce the case with Sales, Legal, and Board groups. Trace how inherited permissions are represented in that list; the work is done when every group assigned to the Group Folder is visible and groups with only inherited permissions are distinguishable.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authorization
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.