nextcloud / nextcloud/groupfolders

When setting ACL to "disallow share", files cannot be renamed in a Team Folder

Open
#4,972 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage bug
Dominant language
PHP
Stars
343
Forks
106
Avg merge
2d 3h
Merged PRs (30d)
34

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.
Steps to reproduce
  1. Create Team Folder
  2. Set ACLs on Team Folder with "disallow share" for group
  3. Log in with a user of that group
  4. Create new file
  5. Try to rename that file
Expected behaviour

The user can rename files (and/or folders) in a Team Folder, even if the share permission is not granted in the ACLs by an admin.

Actual behaviour

We have a Team Folder with advanced ACLs and a user in a group where the ACLs on that Team Folder are set as following:

Image

In the team folder, nothing is shared.

Now, when the user creates a file, this is successful.

When the User wants to rename the file just created, an error message appears that the file cannot be renamed.

In the browser console we can see following error (see below)

As soon as the admin grants the "share" permission in the ACLs of the Team Folder in question, the user can immediately rename a file in that Team Folder.

Server configuration

Operating system:
Ubuntu 24.05

Web server:
nginx

Database:
PostgreSQL

PHP version:
8.3

Nextcloud version: (see Nextcloud admin page)
33.0.7

Team folders version:
21.0.12

Updated from an older Nextcloud/ownCloud or fresh install:
Updated from 32

Where did you install Nextcloud from:
"bare metal", i.e without Docker

Are you using external storage, if yes which one: local/s3/smb/sftp/...
No

Are you using encryption: yes/no
No

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/Saml/...
No

Client configuration

Browser:
Doesn't matter

Operating system:
Doesn't matter

Logs

Nothing in logs

Web server error log

Nothing in Webserver Logs

Nextcloud log (data/nextcloud.log)

Nothing in logs

Browser log
<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:o="http://owncloud.org/ns">
  <s:exception>OCA\DAV\Connector\Sabre\Exception\Forbidden</s:exception>
  <s:message>You cannot move a non-shareable node into a share</s:message>
  <o:retry xmlns:o="o:">false</o:retry>
  <o:reason xmlns:o="o:">You cannot move a non-shareable node into a share</o:reason>
</d:error>

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Team Folder ACL scenario and trace the DAV rename request from the browser error, OCA\DAV\Connector\Sabre\Exception\Forbidden. Compare behavior with and without the share permission; done means a newly created file or folder can be renamed when sharing is disallowed while the stated ACL restriction remains.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authorization, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.