nextcloud / nextcloud/groupfolders

Multiple regressions in TeamFolders > 21.0.0 : Can’t override more than one inherited ACL

Open
#4,706 8 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage bug feature: acl
Dominant language
PHP
Stars
343
Forks
106
Avg merge
2d 3h
Merged PRs (30d)
34

Description

Hello,
Since Teamfolders > 21.0.0, it is not possible to correctly override inherited permissions.

Steps to reproduce
  1. Having a TF configured with two groups, a reader group (R----) and an updater group (RWCD-).  We have a root dir with those permissions, and a ‘subdir’ directory inside
  2. On the subdir, open the share panel and browse the Advanced permissions for Team folder
Image
  1. Edit one permission from one of the two groups (eg. Adding SHARE to ‘updater’). A new line is then created.
Image

As such, we are not able to override more than a single rule in a teamfolder subdirectory.

Expected behaviour

We should be able to override every rules as before, to fine tune our folder structures. Hopefully rules from previous versions are kept, but we haven’t checked.

Actual behaviour

We are not able to override more than a single rule in a teamfolder subdirectory, preventing us to create fine tuned folder structures like before.

Server configuration
• NC 33.0.3
• TF 21.0.7
    ◦ acl-inherit-per-user is true

Tested on multiple Nextcloud Instances

Reported by @ThibautPlg

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Team folder share panel's Advanced permissions flow and reproduce the issue with reader and updater groups on a subdirectory, using the reported Nextcloud 33.0.3 and TeamFolders 21.0.7 configuration. Trace how inherited ACL rules are overridden when a second group permission is edited; done means multiple inherited rules can each be overridden without creating an unusable extra line.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authorization, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.