nextcloud / nextcloud/groupfolders

Prevent shared links from disappearing when moving data into group folder

Open
#458 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement feature: sharing
Dominant language
PHP
Stars
343
Forks
106
Avg merge
2d 3h
Merged PRs (30d)
34

Description

I hope I didn't miss an existing issue on the topic, but at least couldn't find it with some search:

We used to have user folders shared with the team and would like to migrate all those folders and files into group folders.

However, when I move a user folder (that was already shared with group X) into a group folder (of group X), I would prefer to unshare the folder as such with the group, as they now anyway have access. (I know it doesn't actually create a real problems to keep it shared, it's just for the sake of cleanliness and less clutter in the share preferences.)

Unfortunately, unsharing invalidates all shared links that other group members have already created. It seems to me that desirable behaviour would be not to invalidate shared links if they were created by a user that still has access and sharing rights through the group folder feature.

Of course, I am also aware that this might not be possible/feasible to do within the group folder app, but only in the general server. As I can't judge that for sure, sorry in advance if I'm posting to the wrong repo. ;)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how moving a user folder into a group folder and then unsharing it affects existing shared links. Determine whether the behavior belongs in groupfolders or the general server, and identify the relevant implementation and tests before defining completion as preserving links created by users who retain access and sharing rights.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authorization, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.