nextcloud / nextcloud/groupfolders

Trashbin 'Deleted by' column shows 'Unknown' for Group Folder items deleted via desktop client

Open
#4,546 1 comment 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
343
Forks
106
Avg merge
2d 3h
Merged PRs (30d)
34

Description

Description

When files are deleted from a Group Folder (via desktop client or web UI), the trashbin view at /apps/files/trashbin shows "Unknown" in the "Deleted by" column for all Group Folder items.

However, the oc_group_folders_trash table correctly stores the deleted_by value, and the backend TrashBackend.php correctly resolves it via $this->userManager->get($deletedBy).

Steps to reproduce

  1. Enable Group Folders app and create a Group Folder shared with multiple users
  2. User A deletes a file from the Group Folder via the Nextcloud desktop client
  3. Admin views trashbin at /apps/files/trashbin
  4. "Deleted by" column shows "Unknown" for the deleted file

Expected behavior

The "Deleted by" column should show the display name of the user who deleted the file (e.g., "ishizaka").

Actual behavior

The "Deleted by" column shows "Unknown" for all Group Folder trashbin items, even though the backend correctly stores and retrieves the deleted_by value.

Database evidence

SELECT * FROM oc_group_folders_trash;
-- trash_id | folder_id | name            | deleted_time | deleted_by
-- 1        | 1         | test.txt        | 1775308017   | ishizaka    ← correctly stored

Backend verification

  • TrashManager.php correctly queries deleted_by from oc_group_folders_trash
  • TrashBackend.php (line ~449) correctly resolves via $this->userManager->get($deletedBy)
  • GroupTrashItem constructor correctly passes ?IUser $deletedBy to parent TrashItem
  • TrashbinPlugin.php correctly exposes TRASHBIN_DELETED_BY_ID and TRASHBIN_DELETED_BY_DISPLAY_NAME via WebDAV PROPFIND

The issue appears to be in the frontend rendering — the WebDAV properties are likely not being picked up by the trashbin JavaScript frontend.

Environment

  • Nextcloud: 33.0.1
  • Group Folders: latest from app store
  • Primary storage: S3-compatible objectstore (Cloudflare R2)
  • PHP: 8.3.6
  • OS: Ubuntu 24.04 LTS
  • Desktop client: 33.0.2 (Windows)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the trashbin view at /apps/files/trashbin and trace how the frontend consumes the WebDAV properties exposed by TrashbinPlugin.php. Compare those properties with the data passed through TrashManager.php, TrashBackend.php, and GroupTrashItem; done means Group Folder entries display the deleting user's name instead of "Unknown".

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.