nextcloud / nextcloud/groupfolders

`getTrashMount` is always called without `cacheEntry`

Open
#3,935 0 comments 0 reactions 1 assignee View on GitHub

@provokateurin is already working on this.

Since Nov 19, 2025.

2. developing bug
Dominant language
PHP
Stars
343
Forks
106
Avg merge
2d 3h
Merged PRs (30d)
34

Description

https://github.com/nextcloud/groupfolders/blob/9025185f186294bd0dcb44e57d1633c12aab73cc/lib/Mount/MountProvider.php#L162-L184

Is only called from one place:

https://github.com/nextcloud/groupfolders/blob/9025185f186294bd0dcb44e57d1633c12aab73cc/lib/Trash/TrashBackend.php#L396-L403

And a cacheEntry is never passed to getTrashMount. Is it possible to optimize that and pass a cacheEntry? Otherwise the parameter should be removed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.