nextcloud / nextcloud/fulltextsearch
Links to results are wrong when searching in the desktop client
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 234
- Forks
- 64
- Avg merge
- 6h 18m
- Merged PRs (30d)
- 10
Description
As I am not sure if this is only a desktop client issue or also caused by the backend, I mention this here as well.
When doing a fulltext search in the desktop client, the links to documents are generated like this:
https://server.example/apps/files/%3Fdir=/some/folder/&scrollto=somefile.pdf
However, the escaping "%3F" is wrong. This must be "?":
https://server.example/apps/files/?dir=/some/folder/&scrollto=somefile.pdf
Also see https://github.com/nextcloud/desktop/issues/6173
This affects the following versions:
Nextcloud 27.1.2, 27.1.3
Desktop Client 3.10.0, 3.10.1
Fulltext Search 27.0.2
Fulltext Search - Elastic Platform 27.0.4
Fulltext Search - Files 27.0.1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file, test, or entry point is named. Reproduce a full-text search with the listed Nextcloud, desktop client, and search versions, then trace where document links are generated; done means the desktop client opens the documented files URL with an unescaped question mark.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- elasticsearch, php
- Domain
- search
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100