nextcloud / nextcloud/fulltextsearch
Make 'previous page' and 'next page' translatable
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 234
- Forks
- 64
- Avg merge
- 6h 18m
- Merged PRs (30d)
- 10
Description
Hi, currently it is not possible to translate navigation strings between search result pages, because they are hardcoded (see https://github.com/nextcloud/fulltextsearch/blob/4ed9665fd1937cfc6f819833fdc3b47512c650a7/js/fulltextsearch.v1.navigation.js#L405 and https://github.com/nextcloud/fulltextsearch/blob/4ed9665fd1937cfc6f819833fdc3b47512c650a7/js/fulltextsearch.v1.navigation.js#L383
Please mark them as translatable.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open js/fulltextsearch.v1.navigation.js at the referenced lines around 383 and 405 and inspect how the previous-page and next-page labels are defined. Mark both strings for translation, then verify that the navigation still works and that the labels are available to the translation system.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, internationalization
- Issue type
- Feature
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100