nextcloud / nextcloud/files_pdfviewer
Don't lose annotations without warning
Open
Nobody has claimed this yet.
1. to develop
bug
enhancement
- Dominant language
- JavaScript
- Stars
- 108
- Forks
- 61
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 29
Description
The new annotations feature has a downside: when you annotate a document and then close it, your changes aren't saved, nor is there a warning. This has lost me quite some work a few times already 😟
It'd be good to auto-save on close, or at least warn.
Steps to reproduce
- Annotate a PDF
- Close by the X
- Open it
Expected behaviour
Annotations should be there
Actual behaviour
They are gone
Firefox, latest Nextcloud hub 28.0.3.1 on cloud.nextcloud.com ;-)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in the PDF viewer: annotate a PDF, close it with the X, and reopen it. Trace the annotation close and save behavior, then ensure annotations are preserved or that closing presents a warning before changes are lost.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 28/100