nextcloud / nextcloud/files_pdfviewer
Escape key to exit when viewing a PDF
Open
Nobody has claimed this yet.
1. to develop
design
enhancement
- Dominant language
- JavaScript
- Stars
- 108
- Forks
- 61
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 29
Description
Steps to reproduce
- Open a PDF file
- Don't click on anything else
- Press ESC button
Expected behaviour
The viewer should close.
Actual behaviour
It's not closing. (It only closes if you click on the viewer header (where the title and x button are) and then press ESC.
Server configuration
Operating system: Raspbian Linux 11
Database: MySQL
PHP version: 7.4
Nextcloud version: (see Nextcloud admin page) 24.0.2
Client configuration
Browser: Chrome
Operating system: MacOS
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in the PDF viewer with Chrome: open a PDF without clicking elsewhere and press Escape. Inspect the viewer's keyboard and close handling; done means Escape closes the viewer immediately, without first focusing its header.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100