nextcloud / nextcloud/files_pdfviewer

Use filename as document title (i.e. when printing)

Open
#326 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement
Dominant language
JavaScript
Stars
108
Forks
61
Avg merge
2d 9h
Merged PRs (30d)
29

Description

When printing pdf files using the integrated files_pdfviewer app, all print jobs will be titled "PDF.js viewer". This may have its origin in here:
https://github.com/nextcloud/files_pdfviewer/blob/c992b55da9343e412f98e163a5066edcf6bdf37c/templates/viewer.php#L37

Is it possible to use the filename or document title instead? This would make it easier to identify print jobs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting templates/viewer.php at the linked line and trace how the integrated PDF viewer sets the print job title. Check whether the filename or document title is available there, then verify that printing uses the selected document's identifying title instead of "PDF.js viewer".

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.