nextcloud / nextcloud/files_lock

Windows client allows editing locked files and creates conflicted copies

Open
#553 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage bug client: 💻 desktop
Dominant language
JavaScript
Stars
39
Forks
10
Avg merge
1d 11h
Merged PRs (30d)
48

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce
  1. Lock a file.
  2. Open the file as another user in nextcloud files Windows app and edit it
  3. a (conflicted copy <Date,time>).txt file is created.
Expected behaviour

I would expect the system to be unable to open the file because it was locked in the first place

Actual behaviour

The file was edited and a new (conflicted copy <Date,time>).txt

Server configuration

Web server: Apache/Nginx

Database: MySQL/Maria/SQLite/PostgreSQL

PHP version: 8.1/8.2/8.3
8.3.6
Nextcloud version: (see Nextcloud admin page)
3.0.5

List of activated apps
If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder
Nextcloud configuration
If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder
Browser

Browser name: Firefox/Chrome/Safari/…

Browser version: 124/125/…

Operating system: Windows/Ubuntu/Mac/…

Browser log
Insert your browser log here, this could for example include:
a) The javascript console log
b) The network log
c) ...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is identified in the report. Start by reproducing the lock and edit flow with the Windows client, then trace how files_lock handles a write to a locked file. Done means the locked file cannot be edited and no conflicted copy is created.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.