nextcloud / nextcloud/files_lock
Useless (and empty) notification on unlock action on an already unlocked file
Open
Nobody has claimed this yet.
bug
needs info
- Dominant language
- JavaScript
- Stars
- 39
- Forks
- 10
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 48
Description
- userA lock a shared file.
- userB open the webclient and see that the file is locked.
- userA unlock the shared file.
- userB tries to unlock the file (without refreshing the page)
- notification is displayed: Hi there!
The notification should not be displayed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the unlock sequence in the webclient with two users, leaving the second page unrefreshed. Find where the unlock action produces the “Hi there!” notification and verify the behavior after an already-unlocked file is targeted. Done means the empty notification is no longer displayed in this case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100