nextcloud / nextcloud/files_antivirus
Files scanned and modified by ICAP server are not being uploaded to NC
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 112
- Forks
- 44
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 20
Description
Steps to reproduce
- Configure files_antivirus with clamav/ICAP option reqmod or respmod
- Upload a file
Expected behaviour
According to rfc3507, ICAP client should take the data stream from the icap server output.
In case the ICAP server is doing modification to the original file like "content disarm reconstruction" or conversion to different type of file like docx to pdf, file_antivirus addon has to write back the modified file.
Please refferer to: https://datatracker.ietf.org/doc/html/rfc3507
There are multiple threat extraction solution like Opswat or checkpoint sandblast that can run as icap server and can scan and sanitize or disarm files.
Actual behaviour
File that is uploaded to Nextcloud after beein scanned and modified by icap server is not the "disarmed file"
Server configuration
Not Relevant
files_antivirus version 5.0.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the files_antivirus ICAP reqmod/respmod handling and compare its behavior with RFC 3507. Reproduce the upload flow using an ICAP server that modifies a file, then verify that the modified output stream—not the original file—is uploaded to Nextcloud.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100