nextcloud / nextcloud/files_accesscontrol
Feature request: Hide blocked items instead of just disabling them
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 60
- Forks
- 22
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 34
Description
This is not a bug but a feature request.
If anyone is willing to point me in the right direction I would try and implement this myself.
Steps to reproduce
- block any item for a user
- user can still see the item on the backend but can not click on it anymore
wanted behaviour
Hide blocked items altogether
I have looked at the code generated by nextcloud very thoroughly and I can't find any way to distinguish blocked items in the html from normal ones. If that were possible I could just hide them via css but in the example I check everything was exactly the same.
I was trying to hide this element:
<tbody data-cy-files-list-tbody class="files-list__tbody files-list__tbody--list">
Also none of the child elements had anything that would identify the element as blocked. The new :has selector could be used to hide the element but as stated I could not find any way to distinguish the state.
Adding a distinguishing class would be enough to add the option to hide blocked items.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the files-list rendering for blocked items and compare its output with normal items, using the reported files-list__tbody element as the UI entry point. The change is complete when blocked items expose a distinguishing class or state that allows them to be hidden, with the resulting backend markup verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100