nextcloud / nextcloud/files_accesscontrol
Wrong reported permissions on shared external storage
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 60
- Forks
- 22
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 34
Description
Steps
- Create an external storage "/local" of type Local applicable to the "admin" group only
- Create a user "alice" in group "users"
- Create an invisible tag "deny-this"
- Apply the invisible to "/local"
- Share "/local" with "alice" in the files app (using sharing tab)
- Create a rule with the clauses "tag is 'deny-this'" and "user in group 'users'"
- Login as "alice"
- Try accessing "/local"
Expected result
"/local" appears greyed out and its "data-permissions" attribute must not have the readable flag
entering the folder shows a "forbidden" error
Actual result
"/local" is not greyed out and its data-permissions has the readable flag set (31)
entering the folder shows a "forbidden" error, so it's mostly a visual issue
Versions
Nextcloud 22.3.0
files_accesscontrol v1.12.1 and stable22
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the shared external-storage scenario in the issue using Nextcloud 22.3.0, files_accesscontrol v1.12.1, and stable22. Inspect how the Files app sets the data-permissions attribute for the shared /local folder, then verify that denied access removes the readable flag, greys out the folder, and still shows a forbidden error when opened.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authorization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100