nextcloud / nextcloud/external

Add hostname as template param

Open
#221 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement
Dominant language
JavaScript
Stars
132
Forks
43
Avg merge
15m
Merged PRs (30d)
2

Description

Steps to reproduce
  1. Go to url tab of new external site & add http://{url}
Expected behaviour

Expect to see http://localhost when clicked

Actual behaviour

I'm not allowed to save it with that.

My reasoning is that I'm on a shitty At&t router & the damn thing doesn't resolve my local server at my hostname from my internal network. Which means that when I'm at home the hostname would be 192.168.1.* but when I'm out it's my domain. I'm okay with this behavior, but when I wanna make my own embedded apps for my local server I can't because it won't resolve when I'm outside the network. I would like it so that this would grab the hostname from the request info & embed it that way.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the URL tab flow described in the issue, tracing where external-site URLs are validated and saved and where request information is available. Confirm how template parameters are expanded; done means a URL containing {hostname} can be saved and resolves to the request's hostname when the external site is opened.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend, web-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.